Logo Search packages:      
Sourcecode: dbus version File versions

Todo List

Class BusData
get rid of most of these; they should be done with DBusGProxy and the Qt equivalent, i.e. the same way any other interface would be used.

Member dbus_parse_address
document address format in the specification

Member dbus_parse_address
need to be able to escape ';' and ',' in the key values, and the parsing needs to handle that.

Group DBusAuth
some SASL profiles require sending the empty string as a challenge/response, but we don't currently allow that in our protocol.

Group DBusAuth
DBusAuth really needs to be rewritten as an explicit state machine. Right now it's too hard to prove to yourself by inspection that it works.

Group DBusAuth
right now sometimes both ends will block waiting for input from the other end, e.g. if there's an error during DBUS_COOKIE_SHA1.

Group DBusAuth
the cookie keyring needs to be cached globally not just per-auth (which raises threadsafety issues too)

Group DBusAuth
grep FIXME in dbus-auth.c

Member _dbus_auth_decode_data
We need to be able to distinguish "out of memory" error from "the data is hosed" error.

Group DBusBus
right now the default address of the system bus is hardcoded, so if you change it in the global config file suddenly you have to set DBUS_SYSTEM_BUS_ADDRESS env variable. Might be nice if the client lib somehow read the config file, or if the bus on startup somehow wrote out its address to a well-known spot, but might also not be worth it.

Member dbus_bus_acquire_service
these docs are not complete, need to document the return value and flags

Member dbus_bus_acquire_service
if we get an error reply, it has to be converted into DBusError and returned

Member dbus_bus_activate_service
document what the flags do

Member dbus_bus_get
alex thinks we should nullify the connection when we get a disconnect-message.

Member dbus_bus_register
if we get an error reply, it has to be converted into DBusError and returned

Member _dbus_connection_block_pending_call
could use performance improvements (it keeps scanning the whole message queue for example)

Member dbus_connection_add_filter
we don't run filters on messages while blocking without entering the main loop, since filters are run as part of dbus_connection_dispatch(). This is probably a feature, as filters could create arbitrary reentrancy. But kind of sucks if you're trying to filter METHOD_RETURN for some reason.

Member dbus_connection_dispatch
some FIXME in here about handling DBUS_HANDLER_RESULT_NEED_MEMORY

Member dbus_connection_dispatch
FIXME what if we call out to application code to handle a message, holding the dispatch lock, and the application code runs the main loop and dispatches again? Probably deadlocks at the moment. Maybe we want a dispatch status of DBUS_DISPATCH_IN_PROGRESS, and then the GSource etc. could handle the situation? Right now our GSource is NO_RECURSE

Member dbus_connection_open
specify what the address parameter is. Right now it's just the name of a UNIX domain socket. It should be something more complex that encodes which transport to use.

Member dbus_connection_set_watch_functions
We need to drop the lock when we call the add/remove/toggled functions which can be a side effect of setting the watch functions.

Member dbus_connection_unref
in practice it can be quite tricky to never unref a connection that's still connected; maybe there's some way we could avoid the requirement.

Member _dbus_connection_handle_watch
This is basically a hack - we could delete _dbus_transport_handle_watch() and the virtual handle_watch in DBusTransport if we got rid of it. The reason this is some work is threading, see the _dbus_connection_handle_watch() implementation.

Member _dbus_connection_queue_synthesized_message_link
This needs to wake up the mainloop if it is in a poll/select and this is a multithreaded app.

Member dbus_set_error
should be called dbus_error_set()

Member dbus_set_error_const
should be called dbus_error_set_const()

Member _dbus_atomic_dec
implement arch-specific faster atomic ops

Member _dbus_atomic_inc
implement arch-specific faster atomic ops

Member _dbus_concat_dir_and_file
it might be cute to collapse multiple '/' such as "foo//" concat "//bar"

Member _dbus_directory_get_next_file
for thread safety, I think we have to use readdir_r(). (GLib has the same issue, should file a bug.)

Member _dbus_error_from_errno
should cover more errnos, specifically those from open().

Member _dbus_setenv
if someone can verify it's safe, we could avoid the memleak when doing an unset.

Group DBusKeyring
there's a memory leak on some codepath in here, I saw it once when running make check - probably some specific initial cookies present in the cookie file, then depending on what we do with them.

Member _dbus_keyring_validate_context
this is the most inefficient implementation imaginable.

Member _dbus_demarshal_byte_array
Should probably demarshal to a DBusString, having memcpy() in here is Evil(tm).

Member _dbus_demarshal_string
Should we check the string to make sure that it's valid UTF-8, and maybe "fix" the string if it's broken?

Member _dbus_demarshal_string
Should probably demarshal to a DBusString, having memcpy() in here is Evil(tm).

Member _dbus_marshal_set_object_path
implement this function

Member _dbus_marshal_string
: If the string append fails we need to restore the old length. (also for other marshallers)

Member _dbus_marshal_string_len
: If the string append fails we need to restore the old length. (also for other marshallers)

Member _dbus_marshal_validate_arg
security: need to audit this function.

Member _dbus_verbose_bytes
right now it prints even if not in verbose mode

Member DBusMessageLoader
write tests for break-loader that a) randomly delete header fields and b) set string fields to zero-length and other funky values.

Member _dbus_message_loader_get_buffer
this function can be a lot more clever. For example it can probably always return a buffer size to read exactly the body of the next message, thus avoiding any memory wastage or reallocs.

Member _dbus_message_loader_get_buffer
we need to enforce a max length on strings in header fields.

Member _dbus_message_loader_queue_messages
we need to check that the proper named header fields exist for each message type.

Member _dbus_message_loader_queue_messages
If a message has unknown type, we should probably eat it right here rather than passing it out to applications. However it's not an error to see messages of unknown type.

Member INITIAL_LOADER_DATA_LEN
this should be based on min header size plus some average body size, or something. Or rather, the min header size only, if we want to try to read only the header, store that in a DBusMessage, then read only the body and store that, etc., depends on how we optimize _dbus_message_loader_get_buffer() and what the exact message format is.

Member dbus_message_append_args_valist
: Shouldn't this function clean up the changes to the message on failures? (Yes)

Member dbus_message_get_args_valist
We need to free the argument data when an error occurs.

Member dbus_message_iter_append_object_path
add return_val_if_fail(UTF-8 is valid)

Member dbus_message_iter_append_string
add return_val_if_fail(UTF-8 is valid)

Member dbus_message_iter_get_args_valist
this function (or some lower-level non-convenience function) needs better error handling; should allow the application to distinguish between out of memory, and bad data from the remote app. It also needs to not leak a bunch of args when it gets to the arg that's bad, as that would be a security hole (allow one app to force another to leak memory)

Member dbus_message_iter_get_args_valist
We need to free the argument data when an error occurs.

Member _dbus_object_tree_dispatch_and_unlock
thread problems

Member dbus_pending_call_block
when you start blocking, the timeout is reset, but it should really only use time remaining since the pending call was created.

Member dbus_pending_call_get_completed
not thread safe? I guess it has to lock though it sucks

Member dbus_pending_call_get_reply
not thread safe? I guess it has to lock though it sucks

Member dbus_pending_call_get_reply
maybe to make this threadsafe, it should be steal_reply(), i.e. only one thread can ever get the message

Member handle_new_client_fd_and_unlock
unreffing the connection at the end may cause us to drop the last ref to the connection before disconnecting it. That is invalid.

Group DBusServer
Thread safety hasn't been looked at for DBusServer

Group DBusServer
Need notification to apps of disconnection, may matter for some transports

Member dbus_server_listen
error messages on bad address could really be better. DBusResultCode is a bit limiting here.

Group DBusString
DBusString needs a lot of cleaning up; some of the API is no longer used, and the API is pretty inconsistent. In particular all the "append" APIs, especially those involving alignment but probably lots of them, are no longer used by the marshaling code which always does "inserts" now.

Member _dbus_string_ends_with_c_str
memcmp might make this faster.

Member _dbus_string_equal
memcmp is probably faster

Member _dbus_string_equal_len
write a unit test

Member _dbus_string_equal_len
memcmp is probably faster

Member _dbus_string_equal_substring
write a unit test

Member _dbus_string_equal_substring
memcmp is probably faster

Member _dbus_string_move_len
this doesn't do anything with max_length field. we should probably just kill the max_length field though.

Member _dbus_string_pop_line
owen correctly notes that this is a stupid function (it was written purely for test code, e.g. dbus-message-builder.c). Probably should be enforced as test code only with ifdef DBUS_BUILD_TESTS

Member _dbus_string_replace_len
optimize the case where the two lengths are the same, and avoid memmoving the data in the trailing part of the string twice.

Member _dbus_string_replace_len
avoid inserting the source into dest, then deleting the replaced chunk of dest (which creates a potentially large intermediate string). Instead, extend the replaced chunk of dest with padding to the same size as the source chunk, then copy in the source bytes.

Member _dbus_string_steal_data_len
this function is broken because on failure it may corrupt the source string.

Member _dbus_string_validate_ascii
this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Member _dbus_string_validate_error_name
this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Member _dbus_string_validate_interface
this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Member _dbus_string_validate_member
this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Member _dbus_string_validate_nul
this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Member _dbus_string_validate_path
this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Member _dbus_string_validate_path
change spec to disallow more things, such as spaces in the path name

Member _dbus_string_validate_service
this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Member _dbus_string_validate_signature
this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Member _dbus_string_validate_utf8
this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Member _dbus_transport_new_for_domain_socket
once we add a way to escape paths in a dbus address, this function needs to do escaping.

Member unix_do_iteration
We need to have a way to wake up the select sleep if a new iteration request comes in with a flag (read/write) that we're not currently serving. Otherwise a call that just reads could block a write call forever (if there are no incoming messages).

Member _dbus_transport_get_is_authenticated
we drop connection->mutex when calling the unix_user_function, which may not be safe really.

Member _dbus_transport_open
error messages on bad address could really be better. DBusResultCode is a bit limiting here.

Member _dbus_watch_set_handler
this function only exists because of the weird way connection watches are done, see the note in docs for _dbus_connection_handle_watch().

Member dbus_g_proxy_begin_call
this particular function shouldn't die on out of memory, since you should be able to do a call with large arguments.

Member dbus_g_proxy_call_no_reply
this particular function shouldn't die on out of memory, since you should be able to do a call with large arguments.

Member dbus_g_proxy_connect_signal
Right now there's no way to specify the signature to use for invoking the GCallback. Need to either rely on introspection, or require signature here.

Member dbus_set_g_error
expand the DBUS_GERROR enum and take advantage of it here


Generated by  Doxygen 1.6.0   Back to index